Skip to content

test: adjust tests for mandatory tail calls on Win64 #63660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

test: adjust tests for mandatory tail calls on Win64 #63660

merged 1 commit into from
Mar 30, 2023

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Feb 14, 2023 •
edited by AnthonyLatsis
Loading

Since we are force enabling the mandatory tail calls on Windows x64, even at the expense of stack traces and debugging support, adjust the tests to account for the difference.

Resolves #57976

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/llvm-project#6282

@swift-ci please build toolchain Windows platform

@compnerd compnerd mentioned this pull request Feb 14, 2023
Merged
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
test: adjust tests for mandatory tail calls on Win64
4f6a054 
Since we are force enabling the mandatory tail calls on Windows x64,
even at the expense of stack traces and debugging support, adjust the
tests to account for the difference.
@compnerd
Copy link
Member Author

compnerd commented Mar 6, 2023

Please test with following PRs:
swiftlang/llvm-project#6282

@swift-ci please build toolchain Windows platform

2 similar comments
@compnerd
Copy link
Member Author

compnerd commented Mar 8, 2023

Please test with following PRs:
swiftlang/llvm-project#6282

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/llvm-project#6282

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/llvm-project#6281

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/llvm-project#6281

@swift-ci please build toolchain Windows platform

1 similar comment
@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/llvm-project#6281

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/llvm-project#6281
swiftlang/swift-corelibs-foundation#4715

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/llvm-project#6281

@swift-ci please build toolchain Windows platform

@compnerd compnerd mentioned this pull request Mar 17, 2023
Closed
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author 

Failed Tests (3):
  Swift(windows-x86_64) :: IRGen/async/hop_to_executor.sil
  Swift(windows-x86_64) :: IRGen/async/run-call-dynamic-void_to_void.swift
  Swift(windows-x86_64) :: IRGen/async_dynamic_replacement.swift

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/llvm-project#6281

@swift-ci please test Windows platform

@compnerd compnerd marked this pull request as ready for review March 30, 2023 21:17
@compnerd compnerd merged commit 4f24543 into swiftlang:main Mar 30, 2023
@compnerd compnerd deleted the async-tests branch March 30, 2023 21:19
@eeckstein eeckstein mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SR-15697] Program crashes when calling asynchronous method multiple times on Windows
1 participant
@compnerd